[webkit-changes] [WebKit/WebKit] 617de4: Seeking troubles on large WebM files in Safari on ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 617de4cfcf702a68fe29fd77be9c6f13d4cdab18
      https://github.com/WebKit/WebKit/commit/617de4cfcf702a68fe29fd77be9c6f13d4cdab18
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    A LayoutTests/http/tests/media/video-webm-stall-seek-expected.txt
    A LayoutTests/http/tests/media/video-webm-stall-seek.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  -----------
  Seeking troubles on large WebM files in Safari on mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=272095
rdar://125867488

Reviewed by Jer Noble.

We relied on the AVSampleBufferRenderSynchronizer to perform the seek and wait.
It doesn't always behave as expected. So instead we use a NativePromise that will
be resolved once we have demuxed data at the seek location and wait to continue the seek operation.

* LayoutTests/http/tests/media/video-webm-stall-seek-expected.txt: Added.
* LayoutTests/http/tests/media/video-webm-stall-seek.html: Added.
* LayoutTests/platform/glib/TestExpectations: Add failure expectation webkit.org/b/282165
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::~MediaPlayerPrivateWebM):
(WebCore::MediaPlayerPrivateWebM::seekInternal):
(WebCore::MediaPlayerPrivateWebM::seekTo):
(WebCore::MediaPlayerPrivateWebM::appendCompleted):

Canonical link: https://commits.webkit.org/285986@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications