[webkit-changes] [WebKit/WebKit] a57226: Suppress smart pointer warnings in ContainerNode.h

Ryosuke Niwa noreply at github.com
Thu Oct 31 16:02:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a572264d9d39a5f9f403460a25f3d19f974d1a73
      https://github.com/WebKit/WebKit/commit/a572264d9d39a5f9f403460a25f3d19f974d1a73
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/dom/ContainerNode.h

  Log Message:
  -----------
  Suppress smart pointer warnings in ContainerNode.h
https://bugs.webkit.org/show_bug.cgi?id=282408

Reviewed by Geoffrey Garen.

Suppress smart pointer warnings in ContainerNode::ChildChange as adopting smart pointer
in this code results in Speedometer 3 regression.

Also suppress local variable warnings in collectChildNodes. This function which collects
the list of child nodes is obviously safe.

* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/dom/ContainerNode.h:
(WebCore::collectChildNodes):

Canonical link: https://commits.webkit.org/285984@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list