[webkit-changes] [WebKit/WebKit] 196704: ARMv7: Don't emit lsl/asr by zero

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19670468f09f322518f5f19bd980ebbc2c3c7faa
      https://github.com/WebKit/WebKit/commit/19670468f09f322518f5f19bd980ebbc2c3c7faa
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

  Log Message:
  -----------
  ARMv7: Don't emit lsl/asr by zero
https://bugs.webkit.org/show_bug.cgi?id=282391

Reviewed by Justin Michaud.

Zero is not a valid shift amount for those instructions (it is for lsl).
In fact, it encodes a different instruction.

If the shift amount is 32 or higher, we'd end up emitting those forms.
Convert the shift to a move instead.

* Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::rshift32):
(JSC::MacroAssemblerARMv7::urshift32):

Canonical link: https://commits.webkit.org/285970@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications