[webkit-changes] [WebKit/WebKit] 6085aa: [GStreamer] VideoSinkCommon: Do not handle events ...

Alicia Boya García noreply at github.com
Thu Oct 31 09:41:26 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6085aa83ce72d86d727ba4bb4f468af7624cb977
      https://github.com/WebKit/WebKit/commit/6085aa83ce72d86d727ba4bb4f468af7624cb977
  Author: Alicia Boya Garcia <aboya at igalia.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp

  Log Message:
  -----------
  [GStreamer] VideoSinkCommon: Do not handle events while flushing
https://bugs.webkit.org/show_bug.cgi?id=282274

Reviewed by Xabier Rodriguez-Calvar.

WebKitVideoSinkProbe has checks for a number of events, namely tag,
allocation and drain.

Events must not be processed during flushes (doing it anyway is a common
source of deadlocks, for example), but there was no check to prevent
that. This patch adds that.

This is a preventive correctness fix and not motivated by any particular
error report.

* Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(WebKitVideoSinkProbe::doProbe):

Canonical link: https://commits.webkit.org/285957@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list