[webkit-changes] [WebKit/WebKit] d0b1b5: [WebXR] Use minimum near clip plane distance from ...

Ada Chan noreply at github.com
Thu Oct 31 08:17:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0b1b549a5d4c98dacf06d52b880e63740d870c7
      https://github.com/WebKit/WebKit/commit/d0b1b549a5d4c98dacf06d52b880e63740d870c7
  Author: Ada Chan <adachan at apple.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXRSession.cpp
    M Source/WebCore/platform/xr/PlatformXR.h
    M Source/WebKit/Shared/XR/XRDeviceInfo.h
    M Source/WebKit/Shared/XR/XRDeviceProxy.cpp
    M Source/WebKit/Shared/XR/XRDeviceProxy.h
    M Source/WebKit/Shared/XR/XRSystem.serialization.in

  Log Message:
  -----------
  [WebXR] Use minimum near clip plane distance from the system for clamping
https://bugs.webkit.org/show_bug.cgi?id=282321
rdar://138811538

Reviewed by Mike Wyrzykowski.

Instead of hardcoding the minimum near clip plane distance, allow the system
to pass that value via XRDeviceInfo. WebXRSession will get that value
from PlatformXR::Device::minimumNearClipPlane().

* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::WebXRSession):
(WebCore::WebXRSession::applyPendingRenderState):
Set the PlatformXR::RequestData based on the depth range from m_activeRenderState
after the values are clamped.
* Source/WebCore/platform/xr/PlatformXR.h:
(PlatformXR::Device::minimumNearClipPlane const):
* Source/WebKit/Shared/XR/XRDeviceInfo.h:
* Source/WebKit/Shared/XR/XRDeviceProxy.cpp:
(WebKit::XRDeviceProxy::XRDeviceProxy):
* Source/WebKit/Shared/XR/XRDeviceProxy.h:
* Source/WebKit/Shared/XR/XRSystem.serialization.in:

Canonical link: https://commits.webkit.org/285955@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list