[webkit-changes] [WebKit/WebKit] 144f09: [Navigation] NavigationResult.finished resolves ea...

Rob Buis noreply at github.com
Thu Oct 31 06:35:42 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 144f09fb32d5645dd4c7368857f6a98810f9c438
      https://github.com/WebKit/WebKit/commit/144f09fb32d5645dd4c7368857f6a98810f9c438
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/http/wpt/navigation-api/transition-promises-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/autofocus-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/basic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/focus-reset-timing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/multiple-intercept-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/resources/helpers.mjs
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/page/Navigation.cpp

  Log Message:
  -----------
  [Navigation] NavigationResult.finished resolves earlier than expected
https://bugs.webkit.org/show_bug.cgi?id=282137

Reviewed by Alex Christensen.

Add a workaround for waitForAll ending earlier than expected. This fixes most focus-reset
tests but also should help ordering-and-transition tests (currently blocked by https://bugs.webkit.org/show_bug.cgi?id=277948).

* LayoutTests/TestExpectations:
* LayoutTests/http/wpt/navigation-api/transition-promises-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/autofocus-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/focus-reset-timing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/multiple-intercept-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/focus-reset/resources/helpers.mjs:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::innerDispatchNavigateEvent):

Canonical link: https://commits.webkit.org/285951@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list