[webkit-changes] [WebKit/WebKit] a5a85e: images.google.com: Focus Outline is broken for `Sh...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5a85e331e44b68bce0f787e4b2cf443ceae0f5b
      https://github.com/WebKit/WebKit/commit/a5a85e331e44b68bce0f787e4b2cf443ceae0f5b
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    A LayoutTests/fast/block/hugging-outline-with-out-of-flow-child-expected.html
    A LayoutTests/fast/block/hugging-outline-with-out-of-flow-child.html
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  images.google.com: Focus Outline is broken for `Share` and `Save` buttons
https://bugs.webkit.org/show_bug.cgi?id=282335
<<rdar://138113654>

Reviewed by Antti Koivisto.

Out-of-flow descendant content is not supposed to inflate (or affect at all) the hugging 'outline: auto' focus ring rect.

* LayoutTests/fast/block/hugging-outline-with-out-of-flow-child-expected.html: Added.
* LayoutTests/fast/block/hugging-outline-with-out-of-flow-child.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects const):

Canonical link: https://commits.webkit.org/285918@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications