[webkit-changes] [WebKit/WebKit] c29f5f: REGRESSION (Safari 18): Audio from disabled MediaS...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c29f5f0e0f7e949d33dd3457e4e44609a7a7219b
      https://github.com/WebKit/WebKit/commit/c29f5f0e0f7e949d33dd3457e4e44609a7a7219b
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M LayoutTests/fast/mediastream/mediastreamtrack-video-clone-expected.txt
    M LayoutTests/fast/mediastream/mediastreamtrack-video-clone.html
    M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
    M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp

  Log Message:
  -----------
  REGRESSION (Safari 18): Audio from disabled MediaStreamTrack is published
rdar://138321310
https://bugs.webkit.org/show_bug.cgi?id=281758

Reviewed by Eric Carlson.

When cloning or transferring a track, we need to preserve track.enabled.
We make sure to copy this value in MediaStreamTrackPrivate constructor.

When transferring an ended track or a track that is getting ended, the transferring track should be in ended state.
We copy ended in MediaStreamTrackPrivate constructor and we make sure to set the track ready state to ended in MediaStreamTrack::create.

We do not do this in MediaStreamTrack constructor as this path is used for cloning a track.
When cloning a being ended track, we might also want to fire an ended event.
Setting ready state in MediaStreamTrack constructor would prevent this.

* LayoutTests/fast/mediastream/mediastreamtrack-video-clone-expected.txt:
* LayoutTests/fast/mediastream/mediastreamtrack-video-clone.html:
* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):

Canonical link: https://commits.webkit.org/285916@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications