[webkit-changes] [WebKit/WebKit] 2d1526: Remove current IBL resource if empty or incorrect ...

[Alex Marchenko]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d152608cf6e96e894c616aa7702aa768b6c4365
      https://github.com/WebKit/WebKit/commit/2d152608cf6e96e894c616aa7702aa768b6c4365
  Author: Aleksei Marchenko <aleksei at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M LayoutTests/model-element/model-element-environment-map-ready-expected.txt
    M LayoutTests/model-element/model-element-environment-map-ready.html
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebCore/Modules/model-element/HTMLModelElement.h
    M Source/WebCore/Modules/model-element/ModelPlayerClient.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
    M Source/WebKit/WebKitSwift/RealityKit/RKEntity.swift
    M Source/WebKit/WebKitSwift/RealityKit/RealityKitBridging.h
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in

  Log Message:
  -----------
  Remove current IBL resource if empty or incorrect URL provided.

https://bugs.webkit.org/show_bug.cgi?id=282182
rdar://137812845

Reviewed by Ada Chan.

These changes make sure that an empty URL removes provided IBL lighting and
resolves environmentMapPromise. An invalid URL removes IBL lighting as well but
rejects environmentMapPromise.
Also, WKSRKEntity::applyIBL takes a completion handler to provide result of
the asynchronous call. The result is propagated all the way to HTMLModelElement
via didFinishEnvironmentMapLoading(bool).
Last but not least, when environment map resource/URL is provided before model
data is ready, the environment lighting will be applied to the model. That covers
a case when model resource is changed but environment map stays the same.

Canonical link: https://commits.webkit.org/285878@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications