[webkit-changes] [WebKit/WebKit] 582e9b: [JSC] Fix stale assertion in ~GCAwareJITStubRoutin...

Yusuke Suzuki noreply at github.com
Tue Oct 29 19:26:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 582e9ba2bc814140114bcca327996bb42f29bdb9
      https://github.com/WebKit/WebKit/commit/582e9ba2bc814140114bcca327996bb42f29bdb9
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    A JSTests/stress/destroy-GCAwareJITStubRoutineWithExceptionHandler-in-gc-end-phase.js
    M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp
    M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h

  Log Message:
  -----------
  [JSC] Fix stale assertion in ~GCAwareJITStubRoutineWithExceptionHandler
https://bugs.webkit.org/show_bug.cgi?id=282295
rdar://138178660

Reviewed by Keith Miller and Mark Lam.

Running ~GCAwareJITStubRoutineWithExceptionHandler in GC end phase is
fine since mutator is stopped. This fixes stale assertion.

* JSTests/stress/destroy-GCAwareJITStubRoutineWithExceptionHandler-in-gc-end-phase.js: Added.
* Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler):
* Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h:
(JSC::PolymorphicAccessJITStubRoutine::vm):

Canonical link: https://commits.webkit.org/285874@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list