[webkit-changes] [WebKit/WebKit] 70f150: Versioning.

Tue Oct 29 16:27:33 PDT 2024

  Branch: refs/heads/safari-7619.2.8.10-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 70f150784aab189bec55b0b0418e9ac3eae03258
      https://github.com/WebKit/WebKit/commit/70f150784aab189bec55b0b0418e9ac3eae03258
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.1

Canonical link: https://commits.webkit.org/280938.374@safari-7619.2.8.10-branch


  Commit: 4fb4fb0300d511fe7fcf60e2afbda15aaa3cd6eb
      https://github.com/WebKit/WebKit/commit/4fb4fb0300d511fe7fcf60e2afbda15aaa3cd6eb
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.2

Canonical link: https://commits.webkit.org/280938.375@safari-7619.2.8.10-branch


  Commit: b317362f317c7f48faf2a5c9e79da8610a7c526c
      https://github.com/WebKit/WebKit/commit/b317362f317c7f48faf2a5c9e79da8610a7c526c
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.3

Canonical link: https://commits.webkit.org/280938.376@safari-7619.2.8.10-branch


  Commit: 9db163b3269df37ac0622b3977fcf3921637e3e8
      https://github.com/WebKit/WebKit/commit/9db163b3269df37ac0622b3977fcf3921637e3e8
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp
    M Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm

  Log Message:
  -----------
  Cherry-pick 1db982b7c00f. rdar://136779806

    Fix infinite loops when parsing invalid CSP header fields after 273894 at main
    https://bugs.webkit.org/show_bug.cgi?id=280442
    rdar://136779806

    Reviewed by Brent Fulgham.

    If we find an invalid value, report it and return instead of reporting it over and over
    again in an infinite loop until we run out of memory from too many reports.

    * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp:
    (WebCore::ContentSecurityPolicyDirectiveList::parseRequireTrustedTypesFor):
    * Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp:
    (WebCore::ContentSecurityPolicyTrustedTypesDirective::parse):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm:
    (TEST(ContentSecurityPolicy, InvalidRequireTrustedTypesFor)):

    Canonical link: https://commits.webkit.org/284334@main


  Commit: 0e351b41c5306396fcda6e7ba5c34c34095c78c5
      https://github.com/WebKit/WebKit/commit/0e351b41c5306396fcda6e7ba5c34c34095c78c5
  Author: Daniel Liu <danlliu at umich.edu>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/BlockDirectory.cpp
    M Source/JavaScriptCore/heap/BlockDirectory.h
    M Source/JavaScriptCore/heap/CellContainerInlines.h
    M Source/JavaScriptCore/heap/HeapInlines.h
    M Source/JavaScriptCore/heap/MarkedBlock.cpp
    M Source/JavaScriptCore/heap/MarkedBlock.h
    M Source/JavaScriptCore/heap/MarkedSpace.cpp
    M Source/JavaScriptCore/heap/MarkedSpace.h
    M Source/JavaScriptCore/heap/SlotVisitorInlines.h

  Log Message:
  -----------
  Cherry-pick fdd1cb2d2514. rdar://136782494

    Add some investigation code for dumping additional info when MarkedBlock::Handle is invalid
    https://bugs.webkit.org/show_bug.cgi?id=280370
    rdar://136782494

    Reviewed by Mark Lam and Keith Miller.

    We want to dump additional information when this failure case is hit to understand why this
    could be taking place.

    This patch is an updated version of Yijia's patch, which implemented most of the logging.

    * Source/JavaScriptCore/heap/BlockDirectory.cpp:
    (JSC::BlockDirectory::findMarkedBlockHandle):
    * Source/JavaScriptCore/heap/BlockDirectory.h:
    * Source/JavaScriptCore/heap/CellContainerInlines.h:
    (JSC::CellContainer::aboutToMark):
    * Source/JavaScriptCore/heap/HeapInlines.h:
    (JSC::Heap::testAndSetMarked):
    * Source/JavaScriptCore/heap/MarkedBlock.cpp:
    (JSC::MarkedBlock::aboutToMarkSlow):
    (JSC::MarkedBlock::dumpInfoIfHandleIsNotValid):
    * Source/JavaScriptCore/heap/MarkedBlock.h:
    (JSC::MarkedBlock::Handle::hasBlock):
    (JSC::MarkedBlock::Header::handleBitsForNullCheck):
    (JSC::MarkedBlock::aboutToMark):
    * Source/JavaScriptCore/heap/MarkedSpace.cpp:
    (JSC::MarkedSpace::findMarkedBlockHandle):
    * Source/JavaScriptCore/heap/MarkedSpace.h:
    * Source/JavaScriptCore/heap/SlotVisitorInlines.h:
    (JSC::SlotVisitor::appendUnbarriered):
    (JSC::SlotVisitor::appendHiddenUnbarriered):

    Canonical link: https://commits.webkit.org/284376@main


  Commit: 1e2247f89d4524d1253adc74d5cd6d9b813c0bb1
      https://github.com/WebKit/WebKit/commit/1e2247f89d4524d1253adc74d5cd6d9b813c0bb1
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/MarkedBlock.cpp

  Log Message:
  -----------
  Unreviewed build fix
* Source/JavaScriptCore/heap/MarkedBlock.cpp:
(JSC::MarkedBlock::Handle::isFreeListedCell const):


  Commit: 92222cc530a782ad5965aadfbb27d437e8fc63d9
      https://github.com/WebKit/WebKit/commit/92222cc530a782ad5965aadfbb27d437e8fc63d9
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.4

Canonical link: https://commits.webkit.org/280938.380@safari-7619.2.8.10-branch


  Commit: 695a8149c01db8ae2568a5bdd735593547e5caaa
      https://github.com/WebKit/WebKit/commit/695a8149c01db8ae2568a5bdd735593547e5caaa
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/WKContentView.mm

  Log Message:
  -----------
  Revert 4ddf0bdcbfb1. rdar://137239324

Canonical link: https://commits.webkit.org/280938.381@safari-7619.2.8.10-branch


  Commit: 31db2ea2d036cb1ac5fb828ef3623db5d82dee49
      https://github.com/WebKit/WebKit/commit/31db2ea2d036cb1ac5fb828ef3623db5d82dee49
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.5

Canonical link: https://commits.webkit.org/280938.381@safari-7619.2.8.10-branch


  Commit: 2784f5accf86c68b9b8849ac1dd3409d565c691a
      https://github.com/WebKit/WebKit/commit/2784f5accf86c68b9b8849ac1dd3409d565c691a
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm
    M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm

  Log Message:
  -----------
  Cherry-pick 9bcf0c6e31d5. rdar://137522227

    [iOS] Subtitles are lost when moving between native fullscreen and pip modes
    https://bugs.webkit.org/show_bug.cgi?id=279532
    rdar://134372702

    Reviewed by Andy Estes.

    When moving the video content between fullscreen and PiP views, also move the
    subtitle layer, taking care to place the video view below the subtitle layer
    in the view heirarchy.

    Also, to ensure VideoPresentationInterfaceAVKit::setupFullscreen() doesn't move
    the subtitle layer back to the fullscreen WebAVPlayerLayer, only do so when
    that layer does not have a captions layer to begin with.

    * Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm:
    (WebCore::WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
    (WebCore::WebAVPlayerLayerView_stopRoutingVideoToPictureInPicturePlayerLayerView):
    * Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm:
    (WebCore::VideoPresentationInterfaceAVKit::setupFullscreen):

    Canonical link: https://commits.webkit.org/283518@main


  Commit: 2fe927ec272cb05eacf520f612e9bdd5cb1398ca
      https://github.com/WebKit/WebKit/commit/2fe927ec272cb05eacf520f612e9bdd5cb1398ca
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  Cherry-pick 5f8c88f5cf2b. rdar://137522273

    REGRESSION (279761 at main): Returning to inline playback from fullscreen shows only the play/pause button instead of the full controls
    https://bugs.webkit.org/show_bug.cgi?id=280903
    rdar://134924988

    Reviewed by Andy Estes.

    Full control should be displayed when switching back from fullscreen mode, but play/pause button is displayed.

    Steps to reproduce:

    1. Open https://developer.apple.com/videos/play/wwdc2023/10279/ in Safari on macOS
    2. Start video playback
    3. Enter fullscreen
    4. Exit fullscreen

    At this point you’ll notice that the only media control available is the play/pause button instead of the full media controls.

    The issue is introduced with the following commit:
    https://commits.webkit.org/279761@main

    The logic added to HTMLMediaElement::shouldForceControlsDisplay() is for tvOS and no reason to apply it to other platform.
    Wrapping the logic with PLATFORM(APPLETV) should fix the issue.

    * Source/WebCore/html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::shouldForceControlsDisplay const):

    Canonical link: https://commits.webkit.org/284711@main


  Commit: 386b0a04a13a9ba349777c4d385a3daae8c24649
      https://github.com/WebKit/WebKit/commit/386b0a04a13a9ba349777c4d385a3daae8c24649
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  Revert 5f8c88f5cf2b. rdar://137522273


  Commit: 3af5b24cbd8e2f58e892755b4516610d384524e7
      https://github.com/WebKit/WebKit/commit/3af5b24cbd8e2f58e892755b4516610d384524e7
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.6

Canonical link: https://commits.webkit.org/280938.386@safari-7619.2.8.10-branch


  Commit: 4b194cdc6d075e7b601aebe6e533a0c0afbc7503
      https://github.com/WebKit/WebKit/commit/4b194cdc6d075e7b601aebe6e533a0c0afbc7503
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIScriptingCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm

  Log Message:
  -----------
  Cherry-pick 0cc9ba0c387a. rdar://137449521

    Cherry-pick bb35511a7805. rdar://137449521

        Web Extensions: tabs.executeScript ignores frameId parameter.
        https://webkit.org/b/281099
        rdar://137449521

        Reviewed by Brian Weinstein.

        The parsing of options for `tabs.executeScript` was overriding the `frameIdentifier`
        with the main frame since the check for all frames was always returning `true` if
        the `allFrames` option was missing or `false`.

        * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIScriptingCocoa.mm:
        (WebKit::WebExtensionAPIScripting::parseTargetInjectionOptions): Remove early return
        and add `allFrames` else case.
        * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm:
        (WebKit::WebExtensionAPITabs::parseScriptOptions): Make `allFrames` be the else case.
        * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
        (TestWebKitAPI::TEST(WKWebExtensionAPIScripting, ExecuteScriptWithFrameIds)): Replaced
        with a better test that uses pathname to verify the frame is the target.
        * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
        (TestWebKitAPI::TEST(WKWebExtensionAPITabs, ExecuteScriptWithFrameId)): Added.

        Canonical link: https://commits.webkit.org/284915@main


  Commit: 2e90e867b145bb8a169cd265c55edae50d29039a
      https://github.com/WebKit/WebKit/commit/2e90e867b145bb8a169cd265c55edae50d29039a
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7619.2.8.10.7

Canonical link: https://commits.webkit.org/280938.388@safari-7619.2.8.10-branch


Compare: https://github.com/WebKit/WebKit/compare/70f150784aab%5E...2e90e867b145

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications