[webkit-changes] [WebKit/WebKit] a111b2: Crash in `DownloadProxyMap::downloadFinished` duri...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a111b21f3e103c8ee55d2e20092c14dcb6499c0f
      https://github.com/WebKit/WebKit/commit/a111b21f3e103c8ee55d2e20092c14dcb6499c0f
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp

  Log Message:
  -----------
  Crash in `DownloadProxyMap::downloadFinished` during network process teardown
https://bugs.webkit.org/show_bug.cgi?id=282261
rdar://130399446

Reviewed by Chris Dumez.

If `NetworkProcessProxy` begins destruction while the `CancelDownload` message is in flight all downloads
will have already been cleared. Calling `DownloadProxyMap::downloadFinished` with the `DownloadProxy`
being kept alive in the lambda capture will dereference a null `NetworkProcessProxy`.

* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::cancel):

Canonical link: https://commits.webkit.org/285866@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications