[webkit-changes] [WebKit/WebKit] 076938: Clean up permissions for declarativeNetRequestFeed...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 076938a91dda97b5a46bc030ab3393ffed5de812
      https://github.com/WebKit/WebKit/commit/076938a91dda97b5a46bc030ab3393ffed5de812
  Author: Brian Weinstein <bweinstein at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  -----------
  Clean up permissions for declarativeNetRequestFeedback and getMatchedRules
https://bugs.webkit.org/show_bug.cgi?id=282260
rdar://137267655

Reviewed by Timothy Hatcher.

Without this change, there was no way for an extension with activeTab +
declarativeNetRequestFeedback to grant permission to the URLs that would be included in
getMatchedRules.

This PR also passes tabs to some of the permissions checks in declarativeNetRequestGetMatchedRules
in case a first party load is blocked.

* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::declarativeNetRequestGetMatchedRules):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::permissionState):

Canonical link: https://commits.webkit.org/285861@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications