[webkit-changes] [WebKit/WebKit] fe663b: [css-values] Implement attr() fallback support

[Alexsander Borges Damaceno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe663b06e8da7388f053104ca13de9ca48730212
      https://github.com/WebKit/WebKit/commit/fe663b06e8da7388f053104ca13de9ca48730212
  Author: Alexsander Damaceno <aemgbo at gmail.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/css/CSSAttrValue.cpp
    A Source/WebCore/css/CSSAttrValue.h
    M Source/WebCore/css/CSSPrimitiveValue.cpp
    M Source/WebCore/css/CSSPrimitiveValue.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    M Source/WebCore/css/calc/CSSCalcTree+Copy.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Copy.h
    M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+TimingFunction.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/values/CSSPrimitiveNumericTypes.cpp
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  [css-values] Implement attr() fallback support
https://bugs.webkit.org/show_bug.cgi?id=280406

Reviewed by Tim Nguyen.

Implement initial fallback support for attr(), refactor attr into a class to facilitate easier extension for additional features.

* Source/WebCore/Headers.cmake:
* Source/WebCore/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/css/CSSAttrValue.cpp: Added.
(WebCore::CSSAttrValue::create):
(WebCore::CSSAttrValue::equals const):
(WebCore::CSSAttrValue::customCSSText const):
* Source/WebCore/css/CSSAttrValue.h: Added.
* Source/WebCore/css/CSSFontFeatureValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::~CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::stringValue const):
(WebCore::CSSPrimitiveValue::serializeInternal const):
(WebCore::CSSPrimitiveValue::createAttr): Deleted.
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isAttrValue const):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAttr):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueContent):
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt:
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Copy.cpp:
(WebCore::CSSCalc::copy):
* Source/WebCore/css/calc/CSSCalcTree+Copy.h:
* Source/WebCore/css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::isSyntaxValueString const):
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::stringValue const):
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/values/CSSPrimitiveNumericTypes.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+TimingFunction.cpp:

Canonical link: https://commits.webkit.org/285849@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications