[webkit-changes] [WebKit/WebKit] aa2033: [GStreamer] Set URL in the player before calling s...

Yacine Bandou noreply at github.com
Tue Oct 29 09:03:27 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa20333a86f5cb3d8668171bbb0a4f614bf1006f
      https://github.com/WebKit/WebKit/commit/aa20333a86f5cb3d8668171bbb0a4f614bf1006f
  Author: Yacine Bandou <yacine.bandou at softathome.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Set URL in the player before calling setVisibleInViewport function
https://bugs.webkit.org/show_bug.cgi?id=282176

Reviewed by Philippe Normand.

In setVisibleInViewport function we check if we use the mediastream protocol based on the URL.

This commit fixes the start of playback for the Ring application (Amazon) based on WebRTC.

Although we use MediaStream, without this commit, we pause the pipeline in the ‘setVisibleInViewport’
function, because the application starts the video invisibly and the URL is not yet set.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):

Canonical link: https://commits.webkit.org/285839@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list