[webkit-changes] [WebKit/WebKit] 30fb03: Nullptr crash under RenderTreeBuilder::Inline::spl...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30fb035c257c54eb394f0d81ad75007915fa5b6c
      https://github.com/WebKit/WebKit/commit/30fb035c257c54eb394f0d81ad75007915fa5b6c
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    A LayoutTests/fast/css/fullscreen-style-sharing-crash-expected.txt
    A LayoutTests/fast/css/fullscreen-style-sharing-crash.html
    M Source/WebCore/style/StyleSharingResolver.cpp

  Log Message:
  -----------
  Nullptr crash under RenderTreeBuilder::Inline::splitInlines while transitioning to fullscreen
https://bugs.webkit.org/show_bug.cgi?id=282231
rdar://137177522

Reviewed by Alan Baradlay.

* LayoutTests/fast/css/fullscreen-style-sharing-crash-expected.txt: Added.
* LayoutTests/fast/css/fullscreen-style-sharing-crash.html: Added.
* Source/WebCore/style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):

We were improperly sharing style between elements that had different top layer status and fullscreen flags.
This led to illegal render tree structure.

Canonical link: https://commits.webkit.org/285832@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications