[webkit-changes] [WebKit/WebKit] c6e225: [webkitpy] Add --udids option to run-webkit-tests.

Ben noreply at github.com
Tue Oct 29 07:46:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6e2256db28c86d38e380e29bb8d12a69c79dfdf
      https://github.com/WebKit/WebKit/commit/c6e2256db28c86d38e380e29bb8d12a69c79dfdf
  Author: Ben Schwartz <ben_schwartz at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
    M Tools/Scripts/webkitpy/port/device_port.py
    M Tools/Scripts/webkitpy/xcode/simulated_device.py

  Log Message:
  -----------
  [webkitpy] Add --udids option to run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=282198
rdar://138779069

Reviewed by Jonathan Bedard.

This change adds a method of specifying the desired simulator to use to run
layout tests.

The new flow of simulated_device.py:
1. Try to find/boot simulators matching the specified UDID(s) (specify more
    than one by separating with a comma).
2. If device requests remain after handling the devices specified by UDID, try
    to attach to other booted simulators.
3. If we still have device requests after utilizing all available and matching
    existing simulators, create and boot simulators to match the requests.

* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --udids option to `parse_args`.
* Tools/Scripts/webkitpy/port/device_port.py: Pass specified UDIDs to the device manager.
* Tools/Scripts/webkitpy/xcode/simulated_device.py: SimulatedDeviceManager changes to accept and handle new data.
    -> (initialize_devices): Change flow to above.
    -> (_does_fulfill_request): Add option to include non-booted simulators.
    -> (_validate_running_device_against_requests): Move requests validation from `initialize_devices`.

Canonical link: https://commits.webkit.org/285830@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list