[webkit-changes] [WebKit/WebKit] 2b2a4b: [UnifiedPDF] PDFDocumentLayout::indexForPage shoul...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b2a4b0b170906dde32fa34c0505d6ec0a1fd403
      https://github.com/WebKit/WebKit/commit/2b2a4b0b170906dde32fa34c0505d6ec0a1fd403
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm

  Log Message:
  -----------
  [UnifiedPDF] PDFDocumentLayout::indexForPage should use equivalent PDFKit API.
https://bugs.webkit.org/show_bug.cgi?id=282219
rdar://138139244

Reviewed by Aditya Keerthi.

After some discussion it turns out that we should not have our own indexForPage
implementation on top of other PDFKit APIs and instead we should just unconditionally
adopt the equivalent API provided by PDFKit. This was causing some issues with find in
certain PDFs and using [PDFDocument indexForPage] resolves these issues.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::indexForPage const):

Canonical link: https://commits.webkit.org/285823@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications