[webkit-changes] [WebKit/WebKit] fe8874: [WebGPU] Don't allow bind groups with unused exter...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe88747d0133562aad54217c2f1755fa7d2ed385
      https://github.com/WebKit/WebKit/commit/fe88747d0133562aad54217c2f1755fa7d2ed385
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-282097-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-282097.html
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WebGPU] Don't allow bind groups with unused external textures to be used in a shader
https://bugs.webkit.org/show_bug.cgi?id=282097
rdar://137966768

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=282098 tracks correctly
emitting the struct types because carries a little more risk, so
disallow this until it is fully supported. We haven't seen any real
usage of unused external textures in this fashion, so impact is likely zero.

* LayoutTests/fast/webgpu/nocrash/fuzz-282097-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-282097.html: Added.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):

Canonical link: https://commits.webkit.org/285811@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications