[webkit-changes] [WebKit/WebKit] f5992b: DAR/SAR/PAR aspect ratios not respected for VP9 WebM

Jean-Yves Avenard noreply at github.com
Mon Oct 28 19:34:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5992b64d864e380d8053e2161f48a5b0bb0bcc0
      https://github.com/WebKit/WebKit/commit/f5992b64d864e380d8053e2161f48a5b0bb0bcc0
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    A LayoutTests/media/content/test-vp9-dar.webm
    A LayoutTests/media/media-vp9-dar-webm-expected.txt
    A LayoutTests/media/media-vp9-dar-webm.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp
    M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h
    M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
    M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h
    M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm

  Log Message:
  -----------
  DAR/SAR/PAR aspect ratios not respected for VP9 WebM
https://bugs.webkit.org/show_bug.cgi?id=281781
rdar://138642717

Reviewed by Eric Carlson.

Display Aspect Ratio set in the webm container or VP9 bytestream were ignored.
Additionally, prefer the container's display size over the vp9's bytestream one.

Added test.

* LayoutTests/media/content/test-vp9-dar.webm: Added.
* LayoutTests/media/media-vp9-dar-webm-expected.txt: Added.
* LayoutTests/media/media-vp9-dar-webm.html: Added.
* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:
* Source/WebCore/platform/graphics/cocoa/CMUtilities.mm:
(WebCore::createFormatDescriptionFromTrackInfo):
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::WebMParser::VideoTrackData::consumeFrameData):
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h:
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::createVideoInfoFromVPCodecConfigurationRecord):
(WebCore::createVideoInfoFromVP9HeaderParser):
(WebCore::createVideoInfoFromVP8Header):

Canonical link: https://commits.webkit.org/285809@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list