[webkit-changes] [WebKit/WebKit] 2d2554: [ macOS ] TestWebKitAPI.PrivateClickMeasurement.Ep...

Sihui noreply at github.com
Mon Oct 28 19:28:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d255415cfa5f6217ee45b2663e4b20f8415337c
      https://github.com/WebKit/WebKit/commit/2d255415cfa5f6217ee45b2663e4b20f8415337c
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm

  Log Message:
  -----------
  [ macOS ] TestWebKitAPI.PrivateClickMeasurement.EphemeralWithAttributedBundleIdentifier is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=280348
rdar://136703173

Reviewed by Alex Christensen.

WKWebsiteDataStore creates and resolves its directories on a background thread, and the test tries to clear data by
manually deleting directory on the main thread, which leads to unexpected behavior. To fix this, using
WKWebsiteDataStore's API to clear data instead.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::runBasicPCMTest):
(TestWebKitAPI::TEST(PrivateClickMeasurement, EphemeralWithAttributedBundleIdentifier)):
(TestWebKitAPI::clearState): Deleted.

Canonical link: https://commits.webkit.org/285808@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list