[webkit-changes] [WebKit/WebKit] cbc373: Re-enable TestWebKitAPI.WebKit.AutoLayoutIntegrati...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbc373bcac0b399b29cb1e23f177519c08fd10da
      https://github.com/WebKit/WebKit/commit/cbc373bcac0b399b29cb1e23f177519c08fd10da
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm

  Log Message:
  -----------
  Re-enable TestWebKitAPI.WebKit.AutoLayoutIntegration on recent macOS
https://bugs.webkit.org/show_bug.cgi?id=282195
rdar://137216934

Reviewed by Wenson Hsieh.

Sometimes the Util::run call inside _test_waitForDidStartProvisionalNavigation
waits for the didStartProvisionalNavigation call AND the didFinishNavigation call.
When this happened, the following _test_waitForDidFinishNavigation call would set
up a navigation delegate and ask it to wait for a didFinishNavigation call that
happened before the navigation delegate was set up, so it waits forever.
I verified this is what happens when the test times out, and I've run the test
several hundred times with this fix and it hasn't timed out yet.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
(TEST(WebKit, AutoLayoutIntegration)):

Canonical link: https://commits.webkit.org/285800@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications