[webkit-changes] [WebKit/WebKit] 45faeb: [JSC] ASSERT builds should be able to verify calle...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45faeb569e1cf349c75b3892c8d4981ddf86522e
      https://github.com/WebKit/WebKit/commit/45faeb569e1cf349c75b3892c8d4981ddf86522e
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/GPRInfo.h
    M Source/JavaScriptCore/llint/LowLevelInterpreter.asm
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  [JSC] ASSERT builds should be able to verify callee saves are correctly restored by the VM.
https://bugs.webkit.org/show_bug.cgi?id=282122
rdar://138669476

Reviewed by Mark Lam.

In ASSERT_ENABLED builds there's now an option to verify callee save registers are properly
restored when returning from vmEntryToJavaScript/vmEntryToWasm (which is just an alias).
Since doing these checks adds a "frame" to hold the original callee save values this breaks
btjs so it's enabled by passing the new validateVMEntryCalleeSaves options.

* Source/JavaScriptCore/jit/GPRInfo.h:
* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::isAvailable):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/285783@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications