[webkit-changes] [WebKit/WebKit] 43bf13: [iPad] Unable to mute the video on hulu.com

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43bf134a6b6ad911b061d17579fe3b02314f4cc5
      https://github.com/WebKit/WebKit/commit/43bf134a6b6ad911b061d17579fe3b02314f4cc5
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h

  Log Message:
  -----------
  [iPad] Unable to mute the video on hulu.com
https://bugs.webkit.org/show_bug.cgi?id=281697
rdar://126096361

Reviewed by Jer Noble.

Mute implicitly when volume is set to zero on hulu.com on iOS, where we don't have
per-element audio volume control, so their custom controls that use volume to mute and
unmute will work.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Drive-by change, remove unused member
variable `m_initiallyMuted`.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::volume const): Return 0 when implicitly muted.
(WebCore::HTMLMediaElement::setVolume): Mute implicitly when volume set to 0, clear
implicit mute when volume set to anything else.
(WebCore::HTMLMediaElement::muted const): Return true when implicitly muted.
(WebCore::HTMLMediaElement::setMuted): Pass flag to setMutedInternal so it runs the update
logic even when `m_muted` doesn't change bug implicit muted does.
(WebCore::HTMLMediaElement::setMutedInternal):
* Source/WebCore/html/HTMLMediaElement.h:

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::implicitMuteWhenVolumeSetToZero const): New Quirk.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/285768@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications