[webkit-changes] [WebKit/WebKit] a6d261: hover does not apply outline styles if there is al...

Alan Baradlay noreply at github.com
Mon Oct 28 05:32:11 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6d261838dcb9f9e9c7bad991bc3d880ae5358ee
      https://github.com/WebKit/WebKit/commit/a6d261838dcb9f9e9c7bad991bc3d880ae5358ee
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    A LayoutTests/fast/repaint/missing-repaint-when-text-decoration-is-present-expected.txt
    A LayoutTests/fast/repaint/missing-repaint-when-text-decoration-is-present.html
    M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  -----------
  hover does not apply outline styles if there is also a text-decoration style
https://bugs.webkit.org/show_bug.cgi?id=282009
<rdar://problem/138637831>

Reviewed by Antti Koivisto.

Incorrectly early return when text-decoration is present but it requires no layout (overflow computation). We should only return with 'true' here.

* LayoutTests/fast/repaint/missing-repaint-when-text-decoration-is-present-expected.txt: Added.
* LayoutTests/fast/repaint/missing-repaint-when-text-decoration-is-present.html: Added.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow const):

Canonical link: https://commits.webkit.org/285763@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list