[webkit-changes] [WebKit/WebKit] 1f3ae0: REGRESSION(285320 at main): Crash in SystemSettings::...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f3ae07b8e51f7746581f12af28f9728cdaefe68
      https://github.com/WebKit/WebKit/commit/1f3ae07b8e51f7746581f12af28f9728cdaefe68
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/glib/SystemSettings.cpp

  Log Message:
  -----------
  REGRESSION(285320 at main): Crash in SystemSettings::updateSettings
https://bugs.webkit.org/show_bug.cgi?id=282156

Reviewed by Adrian Perez de Castro.

The problem is that SystemSettings::updateSettings() doesn't allow
changes in the observers HashMap while it's being iterated. This
regressed in 285320 at main because now we are properly applying the initial
settings on web process initialization, and RenderTheme singleton is
created from the web process settings observer, which adds its own
observer. We need to use copyToVector when iterating the observers, but
the values are non copyable, so we copy the keys instead and get the
value to call the observer function.

* Source/WebCore/platform/glib/SystemSettings.cpp:
(WebCore::SystemSettings::updateSettings):

Canonical link: https://commits.webkit.org/285761@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications