[webkit-changes] [WebKit/WebKit] 574da2: Large box shadow is not clipped by clip-path() whe...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 574da2d10dd6c9ecb15699207636bb2236efb071
      https://github.com/WebKit/WebKit/commit/574da2d10dd6c9ecb15699207636bb2236efb071
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-10-27 (Sun, 27 Oct 2024)

  Changed paths:
    A LayoutTests/compositing/masks/clip-path-on-tiled-toggle-expected.html
    A LayoutTests/compositing/masks/clip-path-on-tiled-toggle.html
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm

  Log Message:
  -----------
  Large box shadow is not clipped by clip-path() when in scroll container
https://bugs.webkit.org/show_bug.cgi?id=282106
rdar://138599295

Reviewed by Mike Wyrzykowski.

When a layer with a mask toggled between tiled and non-tiled, we correctly call `GraphicsLayerCA::updateMaskLayer()`
on the WebCore side, but on the WebKit side we hit a quirk of CoreAnimation, which is that assigning a CALayer's mask
layer sets the superlayer of the mask layer. If the superlayer was non-nil, we'd assert and early return, rather than
assigning the mask layer to its new owner.

* LayoutTests/compositing/masks/clip-path-on-tiled-toggle-expected.html: Added.
* LayoutTests/compositing/masks/clip-path-on-tiled-toggle.html: Added.
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::updateMask):

Canonical link: https://commits.webkit.org/285742@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications