[webkit-changes] [WebKit/WebKit] b3e744: [UnifiedPDF] PrintWithJSExecutionOptionTests shoul...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3e744b6e0fedd1aacd4aa29b0e1e7611e7c71be
      https://github.com/WebKit/WebKit/commit/b3e744b6e0fedd1aacd4aa29b0e1e7611e7c71be
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-10-26 (Sat, 26 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPrinting.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPrinting.mm

  Log Message:
  -----------
  [UnifiedPDF] PrintWithJSExecutionOptionTests should also work with the feature enabled
https://bugs.webkit.org/show_bug.cgi?id=282088
rdar://138622168

Reviewed by Sammy Gill.

This patch makes it so that PrintWithJSExecutionOptionTests also run
in environments where the Unified PDF feature is enabled. To achieve
this, we split out the PrintWithJSExecutionOptionTests fixture class and
TestPDFPrintDelegate observer into a separate WKPrinting.h header.

We also introduce a `runTest()` method on the fixture class, which runs
the test with a supplied web view. This allows us the flexibility to
spin up a test suite where web views have the Unified PDF feature
enabled.

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::TEST_P):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPrinting.h: Added.
(TestWebKitAPI::PrintWithJSExecutionOptionTests::allowsContentJavascript const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPrinting.mm:
(PrintWithJSExecutionOptionTests::pdfRequest):
(PrintWithJSExecutionOptionTests::testNameGenerator):
(PrintWithJSExecutionOptionTests::runTest):
(TEST_P):
(PrintWithJSExecutionOptionTests::allowsContentJavascript const): Deleted.
(INSTANTIATE_TEST_SUITE_P): Deleted.

Canonical link: https://commits.webkit.org/285738@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications