[webkit-changes] [WebKit/WebKit] e0d7af: WebKitTestRunner should be notified when a site is...

Alex Christensen noreply at github.com
Sat Oct 26 17:32:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0d7af95415bebece598df31b0124fe603bfb57e
      https://github.com/WebKit/WebKit/commit/e0d7af95415bebece598df31b0124fe603bfb57e
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-26 (Sat, 26 Oct 2024)

  Changed paths:
    M LayoutTests/http/tests/site-isolation/iframe-process-termination-after-navigation-completed.html
    M LayoutTests/http/tests/site-isolation/iframe-process-termination.html
    M Source/WebKit/UIProcess/RemotePageProxy.cpp
    M Source/WebKit/UIProcess/RemotePageProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestOptions.cpp
    M Tools/WebKitTestRunner/TestOptions.h

  Log Message:
  -----------
  WebKitTestRunner should be notified when a site isolated iframe crashes
https://bugs.webkit.org/show_bug.cgi?id=282121
rdar://138668277

Reviewed by Charlie Wolfe.

We have 2 tests that intentionally crash an iframe process to see what it looks like thereafter,
 but most of the time we want to actually know when a process crashes that is not the main frame process.

* LayoutTests/http/tests/site-isolation/iframe-process-termination-after-navigation-completed.html:
* LayoutTests/http/tests/site-isolation/iframe-process-termination.html:
* Source/WebKit/UIProcess/RemotePageProxy.cpp:
(WebKit::RemotePageProxy::processDidTerminate):
* Source/WebKit/UIProcess/RemotePageProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::networkProcessDidCrash):
(WTR::TestController::serviceWorkerProcessDidCrash):
(WTR::TestController::gpuProcessDidCrash):
(WTR::TestController::webProcessDidTerminate):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::keyTypeMapping):
* Tools/WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::shouldIgnoreWebProcessTermination const):

Canonical link: https://commits.webkit.org/285735@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list