[webkit-changes] [WebKit/WebKit] 0365e3: Unreviewed, reverting 285708 at main (4692eacc698b)

Jonathan Bedard noreply at github.com
Fri Oct 25 21:14:34 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0365e306403f4fd1b97356a4fea1d154170e69c9
      https://github.com/WebKit/WebKit/commit/0365e306403f4fd1b97356a4fea1d154170e69c9
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-xywh-rect-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/interpolation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/basic-shape-interpolation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-006-expected.txt
    M Source/WTF/wtf/StdLibExtras.h
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    A Source/WebCore/css/BasicShapeConversion.cpp
    A Source/WebCore/css/BasicShapeConversion.h
    A Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp
    A Source/WebCore/css/BasicShapesShapeSegmentConversion.h
    R Source/WebCore/css/CSSBasicShapeValue.cpp
    R Source/WebCore/css/CSSBasicShapeValue.h
    A Source/WebCore/css/CSSBasicShapes.cpp
    A Source/WebCore/css/CSSBasicShapes.h
    M Source/WebCore/css/CSSGradientValue.cpp
    M Source/WebCore/css/CSSGradientValue.h
    R Source/WebCore/css/CSSPathValue.cpp
    R Source/WebCore/css/CSSPathValue.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSRayValue.cpp
    M Source/WebCore/css/CSSRayValue.h
    A Source/WebCore/css/CSSShapeSegmentValue.cpp
    A Source/WebCore/css/CSSShapeSegmentValue.h
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/color/CSSUnresolvedColorKeyword.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.cpp
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.h
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.cpp
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.h
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.cpp
    R Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
    A Source/WebCore/css/values/CSSGradient.cpp
    A Source/WebCore/css/values/CSSGradient.h
    A Source/WebCore/css/values/CSSPosition.cpp
    A Source/WebCore/css/values/CSSPosition.h
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+CSSValueVisitation.h
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+ComputedStyleDependencies.cpp
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+ComputedStyleDependencies.h
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+EvaluateCalc.h
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+Serialization.cpp
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+Serialization.h
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.cpp
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes+SymbolReplacement.h
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes.cpp
    A Source/WebCore/css/values/CSSPrimitiveNumericTypes.h
    A Source/WebCore/css/values/CSSUnevaluatedCalc.cpp
    A Source/WebCore/css/values/CSSUnevaluatedCalc.h
    M Source/WebCore/css/values/CSSValueTypes.h
    R Source/WebCore/css/values/backgrounds/CSSBorderRadius.cpp
    R Source/WebCore/css/values/backgrounds/CSSBorderRadius.h
    R Source/WebCore/css/values/backgrounds/CSSMinimallySerializingRectEdges.h
    R Source/WebCore/css/values/images/CSSGradient.cpp
    R Source/WebCore/css/values/images/CSSGradient.h
    R Source/WebCore/css/values/motion/CSSRayFunction.cpp
    R Source/WebCore/css/values/motion/CSSRayFunction.h
    R Source/WebCore/css/values/primitives/CSSPosition.cpp
    R Source/WebCore/css/values/primitives/CSSPosition.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+CSSValueCreation.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+CSSValueVisitation.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+ComputedStyleDependencies.cpp
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+ComputedStyleDependencies.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+EvaluateCalc.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Serialization.cpp
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Serialization.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+SymbolReplacement.cpp
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+SymbolReplacement.h
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.cpp
    R Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h
    R Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp
    R Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
    R Source/WebCore/css/values/shapes/CSSBasicShape.h
    R Source/WebCore/css/values/shapes/CSSCircleFunction.cpp
    R Source/WebCore/css/values/shapes/CSSCircleFunction.h
    R Source/WebCore/css/values/shapes/CSSEllipseFunction.cpp
    R Source/WebCore/css/values/shapes/CSSEllipseFunction.h
    R Source/WebCore/css/values/shapes/CSSFillRule.h
    R Source/WebCore/css/values/shapes/CSSInsetFunction.cpp
    R Source/WebCore/css/values/shapes/CSSInsetFunction.h
    R Source/WebCore/css/values/shapes/CSSPathFunction.cpp
    R Source/WebCore/css/values/shapes/CSSPathFunction.h
    R Source/WebCore/css/values/shapes/CSSPolygonFunction.cpp
    R Source/WebCore/css/values/shapes/CSSPolygonFunction.h
    R Source/WebCore/css/values/shapes/CSSRectFunction.cpp
    R Source/WebCore/css/values/shapes/CSSRectFunction.h
    R Source/WebCore/css/values/shapes/CSSShapeFunction.cpp
    R Source/WebCore/css/values/shapes/CSSShapeFunction.h
    R Source/WebCore/css/values/shapes/CSSXywhFunction.cpp
    R Source/WebCore/css/values/shapes/CSSXywhFunction.h
    M Source/WebCore/platform/RectEdges.h
    M Source/WebCore/rendering/MotionPath.cpp
    M Source/WebCore/rendering/MotionPath.h
    M Source/WebCore/rendering/PathOperation.cpp
    M Source/WebCore/rendering/PathOperation.h
    M Source/WebCore/rendering/shapes/Shape.cpp
    M Source/WebCore/rendering/shapes/Shape.h
    A Source/WebCore/rendering/style/BasicShapes.cpp
    A Source/WebCore/rendering/style/BasicShapes.h
    A Source/WebCore/rendering/style/BasicShapesShape.cpp
    A Source/WebCore/rendering/style/BasicShapesShape.h
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/SVGRenderStyle.h
    M Source/WebCore/rendering/style/SVGRenderStyleDefs.h
    M Source/WebCore/rendering/style/ShapeValue.cpp
    M Source/WebCore/rendering/style/ShapeValue.h
    M Source/WebCore/rendering/style/StyleGradientImage.cpp
    R Source/WebCore/rendering/style/StylePathData.cpp
    R Source/WebCore/rendering/style/StylePathData.h
    M Source/WebCore/rendering/svg/SVGRenderingContext.cpp
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleResolveForFont.cpp
    A Source/WebCore/style/values/StyleGradient.cpp
    A Source/WebCore/style/values/StyleGradient.h
    A Source/WebCore/style/values/StylePosition.cpp
    A Source/WebCore/style/values/StylePosition.h
    A Source/WebCore/style/values/StylePrimitiveNumericTypes+Conversions.cpp
    A Source/WebCore/style/values/StylePrimitiveNumericTypes+Conversions.h
    A Source/WebCore/style/values/StylePrimitiveNumericTypes.h
    M Source/WebCore/style/values/StyleValueTypes.h
    R Source/WebCore/style/values/backgrounds/StyleBorderRadius.cpp
    R Source/WebCore/style/values/backgrounds/StyleBorderRadius.h
    R Source/WebCore/style/values/backgrounds/StyleMinimallySerializingRectEdges.h
    R Source/WebCore/style/values/images/StyleGradient.cpp
    R Source/WebCore/style/values/images/StyleGradient.h
    R Source/WebCore/style/values/motion/StyleRayFunction.h
    R Source/WebCore/style/values/primitives/StylePosition.cpp
    R Source/WebCore/style/values/primitives/StylePosition.h
    R Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Blending.h
    R Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.cpp
    R Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h
    R Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Evaluation.h
    R Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h
    R Source/WebCore/style/values/shapes/StyleBasicShape.cpp
    R Source/WebCore/style/values/shapes/StyleBasicShape.h
    R Source/WebCore/style/values/shapes/StyleCircleFunction.cpp
    R Source/WebCore/style/values/shapes/StyleCircleFunction.h
    R Source/WebCore/style/values/shapes/StyleEllipseFunction.cpp
    R Source/WebCore/style/values/shapes/StyleEllipseFunction.h
    R Source/WebCore/style/values/shapes/StyleFillRule.h
    R Source/WebCore/style/values/shapes/StyleInsetFunction.cpp
    R Source/WebCore/style/values/shapes/StyleInsetFunction.h
    R Source/WebCore/style/values/shapes/StylePathComputation.h
    R Source/WebCore/style/values/shapes/StylePathFunction.cpp
    R Source/WebCore/style/values/shapes/StylePathFunction.h
    R Source/WebCore/style/values/shapes/StylePolygonFunction.cpp
    R Source/WebCore/style/values/shapes/StylePolygonFunction.h
    R Source/WebCore/style/values/shapes/StyleRectFunction.cpp
    R Source/WebCore/style/values/shapes/StyleRectFunction.h
    R Source/WebCore/style/values/shapes/StyleShapeFunction.cpp
    R Source/WebCore/style/values/shapes/StyleShapeFunction.h
    R Source/WebCore/style/values/shapes/StyleWindRuleComputation.h
    R Source/WebCore/style/values/shapes/StyleXywhFunction.cpp
    R Source/WebCore/style/values/shapes/StyleXywhFunction.h
    M Source/WebCore/svg/SVGPathElement.cpp
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Unreviewed, reverting 285708 at main (4692eacc698b)
https://bugs.webkit.org/show_bug.cgi?id=282127
rdar://138672089

REGRESSION (285708 at main) Broke the macOS debug builds

Reverted change:

    Convert basic shapes types to strongly typed CSS/Style values
    https://bugs.webkit.org/show_bug.cgi?id=281710
    285708 at main (4692eacc698b)

Canonical link: https://commits.webkit.org/285725@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list