[webkit-changes] [WebKit/WebKit] a46b27: Don't crash when UTF-8 conversion of filename in `...

Daniel Liu noreply at github.com
Fri Oct 25 17:12:46 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a46b2777b0cb2e2c7076728045d6225eea1e483a
      https://github.com/WebKit/WebKit/commit/a46b2777b0cb2e2c7076728045d6225eea1e483a
  Author: Daniel Liu <danlliu at umich.edu>
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/jsc.cpp

  Log Message:
  -----------
  Don't crash when UTF-8 conversion of filename in `fetchScriptFromLocalFileSystem` fails
https://bugs.webkit.org/show_bug.cgi?id=281871
rdar://138178550

Reviewed by Yijia Huang.

Previously, `fetchScriptFromLocalFileSystem` assumed that UTF-8 conversion of the filename
would always succeed, and had a `RELEASE_ASSERT` asserting such. However, if this conversion
fails for any reason, we'll trip the assertion. This patch cleans up this case by having the
program fail gracefully.

* Source/JavaScriptCore/jsc.cpp:
(fillBufferWithContentsOfFile):

Canonical link: https://commits.webkit.org/285721@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list