[webkit-changes] [WebKit/WebKit] 356d77: addFusedIfCompare should unbind the scratch early ...

Keith Miller noreply at github.com
Thu Oct 24 13:45:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 356d77d3d47fe099acca4076d4d902f173cfe0bb
      https://github.com/WebKit/WebKit/commit/356d77d3d47fe099acca4076d4d902f173cfe0bb
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
    A JSTests/wasm/stress/bbq-fold-branch-float.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp

  Log Message:
  -----------
  addFusedIfCompare should unbind the scratch early if it doesn't need it
https://bugs.webkit.org/show_bug.cgi?id=282013
rdar://138176414

Reviewed by Mark Lam.

We incorrectly think that we are using a scratch thus assert when we don't end up
using the scratch in addFusedIfCompare in some cases. This patch just releases the
scratch when we don't use it.

* JSTests/wasm/stress/bbq-fold-branch-float.js: Added.
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addFusedIfCompare):

Canonical link: https://commits.webkit.org/285664@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list