[webkit-changes] [WebKit/WebKit] f8da08: [Spatial Video] Controls not always showing when i...

Jean-Yves Avenard noreply at github.com
Thu Oct 24 10:48:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8da0855d4f21c299687e8463cdb40cc369227e4
      https://github.com/WebKit/WebKit/commit/f8da0855d4f21c299687e8463cdb40cc369227e4
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  -----------
  [Spatial Video] Controls not always showing when in spatial portal
https://bugs.webkit.org/show_bug.cgi?id=282041
rdar://136814882

Reviewed by Jer Noble.

We set our `PlayableViewController`'s automaticallyDockOnFullScreenPresentation property to true
whenever the docking icon was being displayed. This affected the presence of the controls being shown
when entered in spatial portal.
As a workaround, we set it back to `NO` if the "enter spatial" button is clicked on.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _enterVideoFullscreenAction:]):

Canonical link: https://commits.webkit.org/285658@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list