[webkit-changes] [WebKit/WebKit] 770fbe: Return MediaTime::zeroTime() when m_mediaTimeDurat...

[ziransun]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 770fbed05b838d191dd40aee6e97c1f83765f2ac
      https://github.com/WebKit/WebKit/commit/770fbed05b838d191dd40aee6e97c1f83765f2ac
  Author: Ziran Sun <zsun at igalia.com>
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

  Log Message:
  -----------
  Return MediaTime::zeroTime() when m_mediaTimeDuration is invalid at MediaPlayerPrivateGStreamerMSE::duration().
https://bugs.webkit.org/show_bug.cgi?id=281291

Reviewed by Alicia Boya Garcia.

Bug 280337 added an assertion on validation check for currentTime in
ManageMediaSource::monitorSourceBuffers(). During currentTime
calculation, we call MediaPlayerPrivateGStreamerMSE::duration() to work out the
playbackpostion for the MSE case. The initial m_mediaTimeDuration is NaN. The creation
of a element has its currentTime attribute set to MediaTime::zeroTime() though.
This causes the assertion failure when ManageMediaSource is enabled.
Affected test is  media/media-source/media-detachablemse-append.html.

* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::duration const):

Canonical link: https://commits.webkit.org/285648@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications