[webkit-changes] [WebKit/WebKit] 68666f: Disable line-fit-edge by default

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68666f27e2e2d79e2ec072658f9c93d66a53f4ff
      https://github.com/WebKit/WebKit/commit/68666f27e2e2d79e2ec072658f9c93d66a53f4ff
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-on-non-root-inline-box-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-on-non-root-inline-box.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h

  Log Message:
  -----------
  Disable line-fit-edge by default
https://bugs.webkit.org/show_bug.cgi?id=281599
<rdar://problem/138051733>

Reviewed by Antti Koivisto.

1. Mark line-fit-edge unstable -> feature is disabled.
2. Ensure that text-box affects inline box size but not its layout bounds (i.e. painting is affected, enclosing line box height is not)

* LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-on-non-root-inline-box-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-on-non-root-inline-box-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-on-non-root-inline-box.html: Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::textBoxTrim const):
(WebCore::Layout::InlineLevelBox::textBoxEdge const):
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
(WebCore::Layout::m_style):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::layoutBoundstWithEdgeAdjustmentForInlineBox):
(WebCore::Layout::textBoxAdjustedInlineBoxHeight):
(WebCore::Layout::LineBoxBuilder::enclosingAscentDescentWithFallbackFonts const):
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox const):
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):
(WebCore::Layout::LineBoxBuilder::applyTextBoxTrimOnLineBoxIfNeeded const):
(WebCore::Layout::LineBoxBuilder::computeLineBoxGeometry const):
(WebCore::Layout::ascentAndDescentWithTextBoxEdgeForInlineBox): Deleted.
(WebCore::Layout::LineBoxBuilder::applyTextBoxTrimIfNeeded const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:

Canonical link: https://commits.webkit.org/285645@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications