[webkit-changes] [WebKit/WebKit] 93b52c: [Intelligence Effects] Factor out the WebCore effe...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93b52cd92be835c366aa826887befa1a716087e3
      https://github.com/WebKit/WebKit/commit/93b52cd92be835c366aa826887befa1a716087e3
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/page/IntelligenceTextEffectsSupport.cpp
    A Source/WebCore/page/IntelligenceTextEffectsSupport.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/writing-tools/WritingToolsController.h
    M Source/WebCore/page/writing-tools/WritingToolsController.mm

  Log Message:
  -----------
  [Intelligence Effects] Factor out the WebCore effects-related functions from WritingToolsController
https://bugs.webkit.org/show_bug.cgi?id=281924
rdar://138374347

Reviewed by Abrar Rahman Protyasha.

Move the intelligence effects related methods into their own file.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/IntelligenceTextEffectsSupport.cpp: Added.
(WebCore::IntelligenceTextEffectsSupport::writingToolsTextSuggestionRectsInRootViewCoordinates):
(WebCore::IntelligenceTextEffectsSupport::updateTextVisibility):
(WebCore::IntelligenceTextEffectsSupport::textPreviewDataForRange):
* Source/WebCore/page/IntelligenceTextEffectsSupport.h: Added.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::proofreadingSessionSuggestionTextRectsInRootViewCoordinates const):
(WebCore::Page::updateTextVisibilityForActiveWritingToolsSession):
(WebCore::Page::textPreviewDataForActiveWritingToolsSession):
* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::proofreadingSessionSuggestionTextRectsInRootViewCoordinates const): Deleted.
(WebCore::WritingToolsController::updateTextVisibilityForActiveSession): Deleted.
(WebCore::WritingToolsController::textPreviewDataForActiveSession): Deleted.

Canonical link: https://commits.webkit.org/285615@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications