[webkit-changes] [WebKit/WebKit] e4d566: [scroll-animations] Refactor animationRange to be ...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4d5669b38e02adac432d98a962d89cc3c68da89
      https://github.com/WebKit/WebKit/commit/e4d5669b38e02adac432d98a962d89cc3c68da89
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
    M Source/WebCore/animation/TimelineRange.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSToStyleMap.cpp
    M Source/WebCore/css/CSSToStyleMap.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/platform/animation/Animation.cpp
    M Source/WebCore/platform/animation/Animation.h
    M Source/WebCore/platform/animation/AnimationList.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [scroll-animations] Refactor animationRange to be on Animation instead of StyleRareNonInheritedData
https://bugs.webkit.org/show_bug.cgi?id=281914
rdar://138426044

Reviewed by Tim Nguyen.

Refactor animationRange to be on Animation, so that we can properly handle sequnces of animationRange
in a future patch, as well as update the underlying WebAnimation via CSSAnimation::syncPropertiesWithBackingAnimation.

* Source/WebCore/animation/TimelineRange.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationRangeStart const):
(WebCore::CSSToStyleMap::mapAnimationRangeEnd const):
* Source/WebCore/css/CSSToStyleMap.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForSingleAnimationRange):
(WebCore::valueForAnimationRange):
(WebCore::addValueForAnimationPropertyToList):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/platform/animation/Animation.cpp:
(WebCore::Animation::Animation):
(WebCore::Animation::animationsMatch const):
* Source/WebCore/platform/animation/Animation.h:
(WebCore::Animation::isRangeStartSet const):
(WebCore::Animation::isRangeEndSet const):
(WebCore::Animation::isEmpty const):
(WebCore::Animation::clearRangeStart):
(WebCore::Animation::clearRangeEnd):
(WebCore::Animation::clearAll):
(WebCore::Animation::rangeStart const):
(WebCore::Animation::rangeEnd const):
(WebCore::Animation::range const):
(WebCore::Animation::setRangeStart):
(WebCore::Animation::setRangeEnd):
(WebCore::Animation::setRange):
(WebCore::Animation::fillRangeStart):
(WebCore::Animation::fillRangeEnd):
(WebCore::Animation::isRangeStartFilled const):
(WebCore::Animation::isRangeEndFilled const):
(WebCore::Animation::isRangeFilled const):
(WebCore::Animation::initialRange):
(WebCore::Animation::initialRangeStart):
(WebCore::Animation::initialRangeEnd):
* Source/WebCore/platform/animation/AnimationList.cpp:
(WebCore::AnimationList::fillUnsetProperties):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialTimelineScope):
(WebCore::RenderStyle::timelineScope const):
(WebCore::RenderStyle::initialAnimationRangeStart): Deleted.
(WebCore::RenderStyle::initialAnimationRangeEnd): Deleted.
(WebCore::RenderStyle::animationRangeStart const): Deleted.
(WebCore::RenderStyle::animationRangeEnd const): Deleted.
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setTimelineScope):
(WebCore::RenderStyle::setAnimationRangeStart): Deleted.
(WebCore::RenderStyle::setAnimationRangeEnd): Deleted.
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:

Canonical link: https://commits.webkit.org/285609@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications