[webkit-changes] [WebKit/WebKit] 62b10c: REGRESSION(284711 at main) No media controls in In-Wi...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62b10ce4776bcc0f6d08135163bf7fc6d60fa2a3
      https://github.com/WebKit/WebKit/commit/62b10ce4776bcc0f6d08135163bf7fc6d60fa2a3
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/media/start-support.js
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  REGRESSION(284711 at main) No media controls in In-Window Fullscreen
https://bugs.webkit.org/show_bug.cgi?id=281860
rdar://137678579

Reviewed by Andy Estes.

Revert the partial revert from 284711 at main and instead fix the underlying issue
causing the "start playback" button to appear when exiting fullscreen: the check
of whether controls are "forced" to be visible needs to happen after the
"fullscreenchange" event fires.

* Source/WebCore/Modules/modern-media-controls/media/start-support.js:
(StartSupport.prototype.get mediaEvents):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldForceControlsDisplay const):

Canonical link: https://commits.webkit.org/285602@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications