[webkit-changes] [WebKit/WebKit] cccc62: PAL::TextCodec::getUnencodableReplacement() should...

Commit Queue noreply at github.com
Tue Oct 22 18:15:18 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cccc626b78256728836f5124f6dd961dcfb3f0ac
      https://github.com/WebKit/WebKit/commit/cccc626b78256728836f5124f6dd961dcfb3f0ac
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/text/TextCodec.cpp
    M Source/WebCore/PAL/pal/text/TextCodec.h
    M Source/WebCore/PAL/pal/text/TextCodecICU.cpp
    M Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp
    M Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp

  Log Message:
  -----------
  PAL::TextCodec::getUnencodableReplacement() should return std::span
<https://bugs.webkit.org/show_bug.cgi?id=281892>
<rdar://138372354>

Reviewed by Darin Adler.

* Source/WebCore/PAL/pal/text/TextCodec.cpp:
(PAL::TextCodec::getUnencodableReplacement):
- Make changes to return std::span.
- Sanity check the return value from snprint() and add ASSERT().
- Use std::span::first() pattern to validate length.
* Source/WebCore/PAL/pal/text/TextCodec.h:
(PAL::TextCodec::getUnencodableReplacement):
- Update to return std::span.
- Add LIFETIME_BOUND for UnencodableReplacementArray reference argument.
* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::urlEscapedEntityCallback):
* Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp:
(PAL::encodeComplexWindowsLatin1):
* Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp:
(PAL::encodeComplexUserDefined):
- Update to use std::span<char> returned from
  TextCodec::getUnencodableReplacement().

Canonical link: https://commits.webkit.org/285580@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list