[webkit-changes] [WebKit/WebKit] 9468b9: [iPadOS] Unable to upload files in Secure Messages...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9468b9f87980b3ff3093fd93b14374dfdb016e97
      https://github.com/WebKit/WebKit/commit/9468b9f87980b3ff3093fd93b14374dfdb016e97
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/dom/GlobalEventHandlers.idl
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebKit/Shared/WebsitePoliciesData.cpp
    M Source/WebKit/Shared/WebsitePoliciesData.h
    M Source/WebKit/Shared/WebsitePoliciesData.serialization.in
    M Source/WebKit/UIProcess/API/APIWebsitePolicies.h
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  -----------
  [iPadOS] Unable to upload files in Secure Messages center on chase.com
https://bugs.webkit.org/show_bug.cgi?id=281905
rdar://126715227

Reviewed by Abrar Rahman Protyasha.

On the desktop version of chase.com, the file upload widget (in the Secure Messages center) disables
file uploads on iPadOS, based on the presence of the DOM window's "ontouchstart" attribute. Add a
quirk to reenable this feature by hiding these DOM attributes on Chase. See below for more details.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/dom/GlobalEventHandlers.idl:

Rename `TouchEventsEnabled` to `TouchEventDOMAttributesEnabled`, to more accurately reflect the fact
that this setting only tracks whether or not the touch event DOM attributes are exposed (not whether
touch events as a whole are enabled).

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldOmitTouchEventDOMAttributesForDesktopWebsite):

Add a new static quirks helper to guard this behavior.

* Source/WebCore/page/Quirks.h:
* Source/WebKit/Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
* Source/WebKit/Shared/WebsitePoliciesData.h:

Add a new `optional<bool>` member that tracks whether or not we should override support for the
touch event handler DOM attributes (`ontouch*`). `nullopt` represents the default behavior, while
`true` / `false` represent the overridden values.

* Source/WebKit/Shared/WebsitePoliciesData.serialization.in:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

When choosing the desktop version of `secure.chase.com`, turn off support for the aforementioned DOM
attributes unless site-specific quirks are disabled.

Canonical link: https://commits.webkit.org/285561@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications