[webkit-changes] [WebKit/WebKit] 9e40a7: Regression(284688 at main) Crash under LayerAncestorC...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e40a77c9c9061b046ae6dcfd77381fc506e86f3
      https://github.com/WebKit/WebKit/commit/9e40a77c9c9061b046ae6dcfd77381fc506e86f3
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
    M Source/WebCore/page/scrolling/ScrollingCoordinator.h
    M Source/WebCore/rendering/LayerAncestorClippingStack.cpp

  Log Message:
  -----------
  Regression(284688 at main) Crash under LayerAncestorClippingStack::updateWithClipData()
https://bugs.webkit.org/show_bug.cgi?id=281876
rdar://138138750

Reviewed by Matt Woodrow.

Allow calling unparentChildrenAndDestroyNode() with an unset ScrollingNodeID, like
before 284688 at main, instead of assuming the ScrollingNodeID is set & valid.

* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::unparentChildrenAndDestroyNode):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:
* Source/WebCore/page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::unparentChildrenAndDestroyNode):
* Source/WebCore/rendering/LayerAncestorClippingStack.cpp:
(WebCore::LayerAncestorClippingStack::updateWithClipData):

Canonical link: https://commits.webkit.org/285553@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications