[webkit-changes] [WebKit/WebKit] 1f1e09: [GStreamer][WebCodecs] Decoders should not inherit...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f1e09a446317e8edd2ff3a63ceeaea1561cc421
      https://github.com/WebKit/WebKit/commit/1f1e09a446317e8edd2ff3a63ceeaea1561cc421
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h

  Log Message:
  -----------
  [GStreamer][WebCodecs] Decoders should not inherit from ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=281858

Reviewed by Chris Dumez.

The audio/video decoder state is managed with a private/internal class so there is no good reason
for the AudioDecoder and VideoDecoder sub-classes to be ThreadSafeRefCounted, instances of those
classes are not captured in any closure.

* Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.cpp:
(WebCore::GStreamerAudioDecoder::create):
* Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
(WebCore::GStreamerVideoDecoder::create):
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h:

Canonical link: https://commits.webkit.org/285550@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications