[webkit-changes] [WebKit/WebKit] 1d5d24: [macOS][Writing Tools] Unable to programmatically ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d5d246b7a48fed314557f08fc59ed09e5333cd6
      https://github.com/WebKit/WebKit/commit/1d5d246b7a48fed314557f08fc59ed09e5333cd6
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [macOS][Writing Tools] Unable to programmatically present a specific tool on `WKWebView`
https://bugs.webkit.org/show_bug.cgi?id=281884
rdar://137513681

Reviewed by Abrar Rahman Protyasha and Richard Robinson.

Implement `-[NSResponder showWritingTools:]`.

* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView showWritingTools:]):

-1 is the default tag for buttons. If encountered, use the default tool value,
which simply presents the panel.

* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::handleContextMenuWritingTools):

Get ahead of another deprecation.

* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::showWritingTools):

Note that a deprecated method is used to present the tool, since its replacement
is not yet available everywhere.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, ShowPanelWithNoSelection)):
(TEST(WritingTools, ShowPanelWithCaretSelection)):
(TEST(WritingTools, ShowPanelWithRangedSelection)):
(TEST(WritingTools, ShowToolWithRangedSelection)):
(TEST(WritingTools, ShowInvalidToolWithRangedSelection)):

Canonical link: https://commits.webkit.org/285547@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications