[webkit-changes] [WebKit/WebKit] 313f0c: [scroll-animations] setting the `timeline` propert...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 313f0ca79b4a9525dee8db157b27ac6917665f8b
      https://github.com/WebKit/WebKit/commit/313f0ca79b4a9525dee8db157b27ac6917665f8b
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/CSSAnimation.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/animation/WebAnimation.idl

  Log Message:
  -----------
  [scroll-animations] setting the `timeline` property via the JS API should override any change to the `animation-timeline` CSS property
https://bugs.webkit.org/show_bug.cgi?id=281847
rdar://138304343

Reviewed by Tim Nguyen.

We make sure that the `animation-timeline` CSS property behaves like other properties related
to animations in that it should no longer affect the animation if the matching JS property, in
this case `timeline`, is set using the JS API.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::bindingsTimeline const):
(WebCore::CSSAnimation::setBindingsTimeline):
* Source/WebCore/animation/CSSAnimation.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setBindingsTimeline):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::bindingsTimeline const):
* Source/WebCore/animation/WebAnimation.idl:

Canonical link: https://commits.webkit.org/285504@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications