[webkit-changes] [WebKit/WebKit] 24571d: Drop IsDeprecatedWeakRefSmartPointerException from...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24571d6c14c80adfa95c868880c487448d6f6899
      https://github.com/WebKit/WebKit/commit/24571d6c14c80adfa95c868880c487448d6f6899
  Author: Rupin Mittal <rupin at apple.com>
  Date:   2024-10-20 (Sun, 20 Oct 2024)

  Changed paths:
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/html/ColorInputType.h
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/EmptyClients.h
    M Source/WebCore/page/Chrome.cpp
    M Source/WebCore/page/Chrome.h
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/platform/ColorChooser.h
    M Source/WebCore/platform/ColorChooserClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm

  Log Message:
  -----------
  Drop IsDeprecatedWeakRefSmartPointerException from WebColorChooser
https://bugs.webkit.org/show_bug.cgi?id=281720
rdar://138165163

Reviewed by Geoffrey Garen and Chris Dumez.

Remove the exception by making WebColorChooser ref-counted. Since it's now
ref-counted, it can out-live it's m_colorChooserClient member. So we make
m_colorChooserClient a WeakPtr and null-check before use.

* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::setValue):
(WebCore::ColorInputType::showPicker):
(WebCore::ColorInputType::endColorChooser):
* Source/WebCore/html/ColorInputType.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createColorChooser):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/Chrome.cpp:
(WebCore::Chrome::createColorChooser):
* Source/WebCore/page/Chrome.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/platform/ColorChooser.h:
* Source/WebCore/platform/ColorChooserClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createColorChooser):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::didChooseColor):
(WebKit::WebColorChooser::didEndChooser):
(WebKit::WebColorChooser::reattachColorChooser):
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h:
(WebKit::WebColorChooser::create):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
(WebKit::WebPage::didEndColorPicker):
(WebKit::WebPage::didChooseColor):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createColorChooser):

Canonical link: https://commits.webkit.org/285496@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications