[webkit-changes] [WebKit/WebKit] aa30e4: [web-animations] Rename `CSSNumberishTime` to `Web...

Antoine Quint noreply at github.com
Sat Oct 19 19:39:25 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa30e476b435875d2bdd3e86cdd63f8af841ffeb
      https://github.com/WebKit/WebKit/commit/aa30e476b435875d2bdd3e86cdd63f8af841ffeb
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-19 (Sat, 19 Oct 2024)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/AnimationEffect.cpp
    M Source/WebCore/animation/AnimationEffect.h
    M Source/WebCore/animation/AnimationEffectTiming.cpp
    M Source/WebCore/animation/AnimationEffectTiming.h
    M Source/WebCore/animation/AnimationPlaybackEvent.cpp
    M Source/WebCore/animation/AnimationPlaybackEvent.h
    M Source/WebCore/animation/AnimationPlaybackEventInit.h
    M Source/WebCore/animation/AnimationTimeline.cpp
    M Source/WebCore/animation/AnimationTimeline.h
    M Source/WebCore/animation/BasicEffectTiming.h
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/CSSAnimation.h
    R Source/WebCore/animation/CSSNumberishTime.cpp
    R Source/WebCore/animation/CSSNumberishTime.h
    M Source/WebCore/animation/ComputedEffectTiming.h
    M Source/WebCore/animation/DocumentTimeline.cpp
    M Source/WebCore/animation/DocumentTimeline.h
    M Source/WebCore/animation/KeyframeInterpolation.cpp
    M Source/WebCore/animation/KeyframeInterpolation.h
    M Source/WebCore/animation/ScrollTimeline.cpp
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/StyleOriginatedAnimation.cpp
    M Source/WebCore/animation/StyleOriginatedAnimation.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h
    A Source/WebCore/animation/WebAnimationTime.cpp
    A Source/WebCore/animation/WebAnimationTime.h
    M Source/WebCore/animation/WebAnimationTypes.h
    M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  [web-animations] Rename `CSSNumberishTime` to `WebAnimationTime`
https://bugs.webkit.org/show_bug.cgi?id=281819
rdar://138242355

Reviewed by Anne van Kesteren.

The name `CSSNumberishTime` is pretty specific to the type of input for timing
values used throughout out the Web Animations codebase. It would be better to
use the name `WebAnimationTime`.

* Source/WebCore/Headers.cmake:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::durationAPIValue):
(WebCore::AnimationEffect::resolutionData const):
(WebCore::AnimationEffect::getBasicTiming const):
(WebCore::AnimationEffect::getComputedTiming const):
(WebCore::AnimationEffect::normalizeSpecifiedTiming):
* Source/WebCore/animation/AnimationEffect.h:
(WebCore::AnimationEffect::iterationDuration const):
(WebCore::AnimationEffect::activeDuration const):
(WebCore::AnimationEffect::endTime const):
* Source/WebCore/animation/AnimationEffectTiming.cpp:
(WebCore::AnimationEffectTiming::updateComputedProperties):
(WebCore::AnimationEffectTiming::getBasicTiming const):
* Source/WebCore/animation/AnimationEffectTiming.h:
* Source/WebCore/animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
* Source/WebCore/animation/AnimationPlaybackEvent.h:
* Source/WebCore/animation/AnimationPlaybackEventInit.h:
* Source/WebCore/animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::AnimationTimeline):
* Source/WebCore/animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::currentTime):
(WebCore::AnimationTimeline::duration const):
* Source/WebCore/animation/BasicEffectTiming.h:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::setBindingsStartTime):
* Source/WebCore/animation/CSSAnimation.h:
* Source/WebCore/animation/ComputedEffectTiming.h:
* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::currentTime):
* Source/WebCore/animation/DocumentTimeline.h:
* Source/WebCore/animation/KeyframeInterpolation.cpp:
(WebCore::transformProgressDuration):
(WebCore::KeyframeInterpolation::interpolateKeyframes const):
* Source/WebCore/animation/KeyframeInterpolation.h:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::ScrollTimeline):
(WebCore::ScrollTimeline::currentTime):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/StyleOriginatedAnimation.cpp:
(WebCore::StyleOriginatedAnimation::bindingsStartTime const):
(WebCore::StyleOriginatedAnimation::bindingsCurrentTime const):
(WebCore::StyleOriginatedAnimation::cancel):
(WebCore::StyleOriginatedAnimation::effectTimeAtStart const):
(WebCore::StyleOriginatedAnimation::effectTimeAtIteration const):
(WebCore::StyleOriginatedAnimation::effectTimeAtEnd const):
(WebCore::StyleOriginatedAnimation::invalidateDOMEvents):
(WebCore::StyleOriginatedAnimation::enqueueDOMEvent):
* Source/WebCore/animation/StyleOriginatedAnimation.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::isTimeValid const):
(WebCore::WebAnimation::setBindingsStartTime):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::setBindingsCurrentTime):
(WebCore::WebAnimation::currentTime const):
(WebCore::WebAnimation::silentlySetCurrentTime):
(WebCore::WebAnimation::setCurrentTime):
(WebCore::WebAnimation::zeroTime const):
(WebCore::WebAnimation::effectEndTime const):
(WebCore::WebAnimation::cancel):
(WebCore::WebAnimation::enqueueAnimationPlaybackEvent):
(WebCore::WebAnimation::finishNotificationSteps):
(WebCore::WebAnimation::autoAlignStartTime):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::startTime const):
(WebCore::WebAnimation::bindingsCurrentTime const):
(WebCore::WebAnimation::holdTime const):
* Source/WebCore/animation/WebAnimationTime.cpp: Renamed from Source/WebCore/animation/CSSNumberishTime.cpp.
(WebCore::WebAnimationTime::WebAnimationTime):
(WebCore::WebAnimationTime::fromMilliseconds):
(WebCore::WebAnimationTime::fromPercentage):
(WebCore::WebAnimationTime::time const):
(WebCore::WebAnimationTime::percentage const):
(WebCore::WebAnimationTime::isValid const):
(WebCore::WebAnimationTime::isInfinity const):
(WebCore::WebAnimationTime::isZero const):
(WebCore::WebAnimationTime::matchingZero const):
(WebCore::WebAnimationTime::matchingEpsilon const):
(WebCore::WebAnimationTime::approximatelyEqualTo const):
(WebCore::WebAnimationTime::approximatelyLessThan const):
(WebCore::WebAnimationTime::approximatelyGreaterThan const):
(WebCore::WebAnimationTime::operator+ const):
(WebCore::WebAnimationTime::operator- const):
(WebCore::WebAnimationTime::operator/ const):
(WebCore::WebAnimationTime::operator+=):
(WebCore::WebAnimationTime::operator-=):
(WebCore::WebAnimationTime::operator< const):
(WebCore::WebAnimationTime::operator<= const):
(WebCore::WebAnimationTime::operator> const):
(WebCore::WebAnimationTime::operator>= const):
(WebCore::WebAnimationTime::operator== const):
(WebCore::WebAnimationTime::operator* const):
(WebCore::WebAnimationTime::operator Seconds const):
(WebCore::WebAnimationTime::operator CSSNumberish const):
(WebCore::WebAnimationTime::dump const):
(WebCore::operator<<):
* Source/WebCore/animation/WebAnimationTime.h: Renamed from Source/WebCore/animation/CSSNumberishTime.h.
* Source/WebCore/animation/WebAnimationTypes.h:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::buildObjectForEffect):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/285481@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list