[webkit-changes] [WebKit/WebKit] 341475: Correctly update PDFPageCoverage for selection

Simon Fraser noreply at github.com
Fri Oct 18 21:23:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 341475f40f37474d301a9b43e2323a756dfafc91
      https://github.com/WebKit/WebKit/commit/341475f40f37474d301a9b43e2323a756dfafc91
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  Correctly update PDFPageCoverage for selection
https://bugs.webkit.org/show_bug.cgi?id=281783
rdar://138212327

Reviewed by Abrar Rahman Protyasha.

285170 at main added a new field to PagePageInfo in PDFPageCoverage, but failed to initialize
it at two call sites that make PDFPageCoverage for selection, so fix that.

We should share more code between these two call sites.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::pageCoverageForSelection const):
(WebKit::UnifiedPDFPlugin::rectsForTextMatch):

Canonical link: https://commits.webkit.org/285458@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list