[webkit-changes] [WebKit/WebKit] bc864a: Enhanced <input type=color>: support alpha picker ...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc864a70fe065beabd4c062cbe994b1a685687d7
      https://github.com/WebKit/WebKit/commit/bc864a70fe065beabd4c062cbe994b1a685687d7
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/html/ColorInputType.h
    M Source/WebCore/platform/ColorChooserClient.h
    M Source/WebKit/Shared/ColorControlSupportsAlpha.h
    M Source/WebKit/Shared/FocusedElementInformation.serialization.in
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebColorPickerMac.h
    M Source/WebKit/UIProcess/mac/WebColorPickerMac.mm
    M Source/WebKit/UIProcess/win/PageClientImpl.cpp
    M Source/WebKit/UIProcess/win/PageClientImpl.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Enhanced <input type=color>: support alpha picker on macOS
https://bugs.webkit.org/show_bug.cgi?id=281304
rdar://137751805

Reviewed by Wenson Hsieh.

Enable the macOS color picker to show its alpha slider when the
corresponding preference is enabled and the alpha attribute is used.
Guard the usage in UIProcess using MESSAGE_CHECK.

Also properly namespace ColorControlSupportsAlpha.

* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::supportsAlpha const):
* Source/WebCore/html/ColorInputType.h:
* Source/WebCore/platform/ColorChooserClient.h:
* Source/WebKit/Shared/ColorControlSupportsAlpha.h:
* Source/WebKit/Shared/FocusedElementInformation.serialization.in:
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.h:
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showColorPicker):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:
(-[WKColorPicker updateColorPickerState]):
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/mac/WebColorPickerMac.h:
* Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:
(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::WebColorPickerMac):
(WebKit::WebColorPickerMac::showColorPicker):
(-[WKColorPopoverMac setAndShowPicker:withColor:supportsAlpha:suggestions:]):
(-[WKColorPopoverMac setAndShowPicker:withColor:suggestions:]): Deleted.
* Source/WebKit/UIProcess/win/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/win/PageClientImpl.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::reattachColorChooser):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::focusedElementInformation):

Canonical link: https://commits.webkit.org/285446@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications