[webkit-changes] [WebKit/WebKit] b7c11f: [visionOS] Allow image updates when fullscreen is ...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7c11fccb9fbe96df0a6725fe9c6ea34891cfee5
      https://github.com/WebKit/WebKit/commit/b7c11fccb9fbe96df0a6725fe9c6ea34891cfee5
  Author: Yoel Hawa <yoel at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M Source/WebCore/loader/ImageLoader.cpp
    M Source/WebCore/page/ChromeClient.h
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
    M Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift
    M Source/WebKit/WebKitSwift/Preview/WKSPreviewWindowController.h
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h

  Log Message:
  -----------
  [visionOS] Allow image updates when fullscreen is delegated to Quick Look
https://bugs.webkit.org/show_bug.cgi?id=281592
<rdar://136326912>

Reviewed by Andy Estes.

When an image source changes while in fullscreen with Quick look,
send that new image source over to Quick Look to update the image
being displayed.

* Source/WebCore/loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
Listen for new image sources to finish loading.

* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::updateImageSource):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::updateImageSource):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::updateImageSource):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController updateImageSource]):
* Source/WebKit/WebKitSwift/Preview/WKSPreviewWindowController.h:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::getImageMediaDetails):
(WebKit::WebFullScreenManager::enterFullScreenForElement):
(WebKit::WebFullScreenManager::updateImageSource):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::updateImageSource):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
Plumb the new image data to the UI Process if we currently have an
image open in fullscreen via Quick Look.

* Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift:
(item):
(windowOpenedContinuation):
(presentWindow):
(updateImage(_:)):
Wait until the Quick Look window is ready if it isn't already, then
update the Quick Look scene with the new image.

Canonical link: https://commits.webkit.org/285443@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications