[webkit-changes] [WebKit/WebKit] b445bf: Add support for documentId to tabs.sendMessage() a...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b445bf7d0185f8c7613c499f9a28370286979da8
      https://github.com/WebKit/WebKit/commit/b445bf7d0185f8c7613c499f9a28370286979da8
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    A Source/WebKit/Shared/Extensions/WebExtensionMessageTargetParameters.h
    A Source/WebKit/Shared/Extensions/WebExtensionMessageTargetParameters.serialization.in
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
    M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITabs.h
    M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h
    M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm

  Log Message:
  -----------
  Add support for documentId to tabs.sendMessage() and tabs.connect().
https://webkit.org/b/281084
rdar://problem/137532897

Reviewed by Brian Weinstein.

Added support for sending messages or connecting with a `documentId` instead of a `frameId`.
To make this more future-proof, I added this via a new `WebExtensionMessageTargetParameters`
struct that contains wither a frame or document identifier.

* Source/WebKit/DerivedSources-input.xcfilelist: Added new file and fixed sorting.
* Source/WebKit/DerivedSources.make: Ditto.
* Source/WebKit/Shared/Extensions/WebExtensionMessageTargetParameters.h: Added.
* Source/WebKit/Shared/Extensions/WebExtensionMessageTargetParameters.serialization.in: Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsSendMessage):
(WebKit::WebExtensionContext::tabsConnect):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj: Added new files and fixed sorting.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContextProxy::internalDispatchRuntimeMessageEvent):
(WebKit::WebExtensionContextProxy::dispatchRuntimeMessageEvent):
(WebKit::WebExtensionContextProxy::internalDispatchRuntimeConnectEvent):
(WebKit::WebExtensionContextProxy::dispatchRuntimeConnectEvent):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm:
(WebKit::WebExtensionAPITabs::parseSendMessageOptions):
(WebKit::WebExtensionAPITabs::parseConnectOptions):
(WebKit::WebExtensionAPITabs::sendMessage):
(WebKit::WebExtensionAPITabs::connect):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITabs.h:
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h:
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, Errors)): Added new error checks.
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageFromBackgroundToSpecificFrame)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageFromBackgroundToSpecificDocument)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, ConnectToSpecificFrame)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, ConnectToSpecificDocument)): Added.

Canonical link: https://commits.webkit.org/285438@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications